Skip to content

fix: take outroing elements out of the flow when animating siblings #11208

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 17, 2024
Merged

fix: take outroing elements out of the flow when animating siblings #11208

merged 2 commits into from
Apr 17, 2024

Conversation

Rich-Harris
Copy link
Member

No test because you can't really test for this stuff in JSDOM. Fixes #10867

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests and linting

  • Run the tests with pnpm test and lint the project with pnpm lint

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Apr 17, 2024

🦋 Changeset detected

Latest commit: 92db5b8

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
svelte Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

trueadm
trueadm approved these changes Apr 17, 2024
View reviewed changes
Copy link
Contributor

@trueadm trueadm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@Rich-Harris Rich-Harris merged commit c44234d into main Apr 17, 2024
@Rich-Harris Rich-Harris deleted the gh-10867 branch April 17, 2024 20:54
@github-actions github-actions bot mentioned this pull request Apr 17, 2024
Merged
@brunnerh brunnerh mentioned this pull request Apr 17, 2024
Closed
Rich-Harris added a commit that referenced this pull request Apr 18, 2024
@Rich-Harris
Revert "fix: take outroing elements out of the flow when animating si…
3a6a482 
…blings (#11208)"

This reverts commit c44234d.
@Rich-Harris Rich-Harris mentioned this pull request Apr 18, 2024
Merged
5 tasks
Rich-Harris added a commit that referenced this pull request Apr 18, 2024
@Rich-Harris
fix: measure elements before taking siblings out of the flow (#11216)
5665498 
* Revert "fix: take outroing elements out of the flow when animating siblings (#11208)"

This reverts commit c44234d.

* fix: measure elements before taking siblings out of the flow

* lint

* add changeset back

* changeset
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trueadm trueadm trueadm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Svelte 5: FLIP animations don't take outroing elements out of the flow
2 participants
@Rich-Harris @trueadm